Repository navigation
Migrate packaging to pyproject and add the shared plugin tests - #1
Merged
Merged
Conversation
- pyproject.toml + hatch_build.py replace setup.py, MANIFEST.in and plugin_info.toml (entry points are generated from the [features] table, version comes from git tags) - tests/test_plugin_package_structure.py: acceptance checks from pymodaq.utils.plugin_testing - .github/workflows: tests, compatibility and publish call the shared workflows of PyMoDAQ/pymodaq_plugins_template (legacy Test.yml/Testbase.yml removed) - AGENTS.md / CLAUDE.md for AI coding assistants Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
The shared tests and the template target pymodaq>=5.3.2 (pymodaq_utils>=5.3.1, pymodaq_gui and pymodaq_data>=5.3.0), so releases of this plugin cannot be installed next to an older PyMoDAQ. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: the plugin was packaged with
setup.py,MANIFEST.inandplugin_info.toml, with legacy test workflows.After: it uses the same
pyproject.toml(hatch) layout as the other PyMoDAQ plugins, runs the shared acceptance tests, and calls the shared CI workflows.What changes:
pyproject.tomlandhatch_build.pyreplacesetup.py,MANIFEST.inandplugin_info.toml. Metadata, dependencies and features are carried over; entry points are generated from the[features]table and the version comes from git tags (hatch-vcs). The distribution keeps its existing namepymodaq_plugins_alcatel(the package directory), which differs from the repository name.tests/test_plugin_package_structure.pyruns the acceptance checks frompymodaq.utils.plugin_testing..github/workflows/tests.yml,compatibility.ymlandpython-publish.ymlcall the shared workflows ofPyMoDAQ/pymodaq_plugins_template; legacy workflows are removed.AGENTS.md/CLAUDE.mdfor AI coding assistants.How: files generated by a script from the plugin template, the wheel was built locally to check metadata and entry points. The tests and CI results of this PR show what the plugin still needs for the current PyMoDAQ; the plugin code itself is not modified. Nothing here was run against real hardware.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
Generated by Claude Code