Repository navigation
Expose the SLM geometry and calibration (shaper contract of pymodaq_plugins_utils) - #5
Merged
Merged
Conversation
…size from slmsuite Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CAhZwmbyCSpSgfTyicUxuS
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CAhZwmbyCSpSgfTyicUxuS
…nal calibration (slmsuite LUT, Meadowlark) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CAhZwmbyCSpSgfTyicUxuS
…se with the shaper contract) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CAhZwmbyCSpSgfTyicUxuS
seb5g
marked this pull request as ready for review
October 30, 2026 09:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pymodaq_plugins_utils(>=5.3.4,hardware/shaper.py):shaper_geometry(width,height,pixel_size_x,pixel_size_y, µm) andshaper_propertiesgroups, filled inini_stagefrom slmsuite (slm.shape,slm.pitch_um). The pixel size is what the driver reports (Holoeye SDK, Meadowlark SDK when it can, else the 8 µm default of slmsuite; settable withpitch_umin the arguments). The BeamShaping extension builds itsShaperfrom them (Get the Shaper (geometry, calibration) from the Shaper actuator pymodaq_plugins_beam_shaping#61).has_internal_calibrationis True for Meadowlark (lookup table loaded from the hardware by its SDK) or when slmsuite knows alutfor the SLM; False otherwise.SlmController.pitch_umandSlmController.has_internal_calibration.pymodaq_plugins_utils>=5.3.4; no beam_shaping import.Tests
Simulated SLM and fake controller (geometry, properties, LUT). Not tested on real SLMs.
🤖 Generated with Claude Code
https://claude.ai/code/session_01CAhZwmbyCSpSgfTyicUxuS