Repository navigation
Test the Dashboard extension of the template with PluginExtensionChecks - #65
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
The template ships a Dashboard extension (
CustomExtensionTemplate) but its tests did not load it, and AGENTS.md did not mention how to test an extension.After:
tests/test_plugin_extensions.pysubclassesPluginExtensionChecks(PyMoDAQ 5.3.7): each extension of theextensionsfolder is loaded in an empty Dashboard and closed. AGENTS.md has a short "Testing a Dashboard extension" paragraph (loaded_extension). Thepymodaqfloor is raised to 5.3.7, where the checks exist (check_template_versions.pyreports the versions as consistent).How: the test file skips itself when PyMoDAQ is older than 5.3.7 or not installed, like the package structure test.
Tested:
pytest testswith PyMoDAQ from the 5.3.x monorepo, offscreen, PySide6 6.11.2: 18 passed, including the extension load and close. Not tested: PyQt5 / PyQt6 locally (CI matrix), and a plugin created from the template with real instruments.Generated by Claude Code