Skip to content

CameraBase: hardware_averaging is True, the camera averages the frames - #17

Merged
seb5g merged 1 commit into
5.3.xfrom
fix/camera-base-hardware-averaging
Oct 30, 2026
Merged

seb5g merged 1 commit into
5.3.xfrom
fix/camera-base-hardware-averaging

Conversation

@seb5g

@seb5g seb5g commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Before: CameraBase.hardware_averaging was False, although the camera thread already averages Naverage frames (Grab.n_average). The viewer then averaged the averaged frames a second time (Naverage x Naverage frames for one displayed image).

After: hardware_averaging = True. This was left False until the live mode of the DAQ_Viewer no longer depended on it (PyMoDAQ #1421, fixed in pymodaq 5.3.9, which is already the floor of this package), so it can be set now.

How: one attribute and its comment in camera_base.py, and a test that states the two class attributes (live_mode_available and hardware_averaging) with the reason.

Tested: tests/ with the fake camera: 66 passed, 2 skipped, 1 failed. The failure is entry point ... points to pymodaq_plugins_utils of the package structure test: the package is not installed in my sandbox, so it is not related to this change. The camera tests of pymodaq_plugins_mockexamples (CookbookCamera, BSCamera) pass with this version (31 passed). Not tested: a real camera, nor the opencv plugin.


Generated by Claude Code

seb5g commented Oct 30, 2026

Copy link
Copy Markdown
Contributor Author

The windows-latest / Python 3.12 / pyqt6 job was cancelled after running for 30 minutes (started 10:28, cancelled 10:58) while the other 5 jobs, including the tests, passed. The change only sets two class attributes, so it is not this PR's. I re-ran the job once.


Generated by Claude Code

@seb5g
seb5g merged commit 61bef3f into 5.3.x Oct 30, 2026
10 of 12 checks passed
@seb5g
seb5g deleted the fix/camera-base-hardware-averaging branch October 30, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants