Repository navigation
CameraBase: hardware_averaging is True, the camera averages the frames - #17
Merged
Merged
Conversation
…True Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
Contributor
Author
|
The Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
CameraBase.hardware_averagingwas False, although the camera thread already averagesNaverageframes (Grab.n_average). The viewer then averaged the averaged frames a second time (Naverage x Naverage frames for one displayed image).After:
hardware_averaging = True. This was left False until the live mode of theDAQ_Viewerno longer depended on it (PyMoDAQ #1421, fixed in pymodaq 5.3.9, which is already the floor of this package), so it can be set now.How: one attribute and its comment in
camera_base.py, and a test that states the two class attributes (live_mode_availableandhardware_averaging) with the reason.Tested:
tests/with the fake camera: 66 passed, 2 skipped, 1 failed. The failure isentry point ... points to pymodaq_plugins_utilsof the package structure test: the package is not installed in my sandbox, so it is not related to this change. The camera tests ofpymodaq_plugins_mockexamples(CookbookCamera, BSCamera) pass with this version (31 passed). Not tested: a real camera, nor the opencv plugin.Generated by Claude Code