Repository navigation
Conversation
…tialized again Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CAhZwmbyCSpSgfTyicUxuS
Contributor
Author
|
Closing: this PR kept the value restored from the loaded state, but the settings of the shaper are meant to be refreshed at each (re)initialization of the actuator. The choice of using the internal calibration is now a preference of BeamShaping, imposed to the actuator by the extension (PyMoDAQ/pymodaq_plugins_beam_shaping#63), so Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fill_shaper_settings(called inini_stage) resetuse_internal_calibrationtohas_internal_calibrationat each initialization, so the choice of the user (restored from the preset) was overwritten every time the experiment file was loaded.Now the value is set to
has_internal_calibrationonly the first time, or whenhas_internal_calibrationchanged since the settings were saved (another controller). Otherwise the restored choice is kept. It is never True without an internal calibration.Tests added for both cases (
tests/test_shaper.py, 10 passed). Not tested with a real preset reload in the Dashboard.Generated by Claude Code