Repository navigation
remove all functionality deprecated in PyO3 0.28 - #6519
Merged
Merged
Conversation
Member
Author
|
To allow the release to ship, I'm just going to set this to merge. I think there should be no concerns with this. |
davidhewitt
enabled auto-merge
October 13, 2026 14:24
Tpt
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all functionality deprecated in PyO3 0.28 (so these items can be removed in #6493).
While at it, I spotted a bunch of dead doctests which had
compile_failmarked in the migration guide, and one injiff.rswhich had a#![cfg_attr()]- all of these were running outside of the merged doctests. I set thecompile_failones in the migration guide to beignore, and tweaked the jiff one so it could join the merged run.