Add explicit serialization codec versioning - #720
Merged
Merged
Conversation
Contributor
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Contributor
|
zhenrongliew
added
the
category: breaking change
Roger-luo
approved these changes
Sep 11, 2026
Collaborator
|
@zhenrongliew I think 1 review should be good, let's get this in! |
zhenrongliew
force-pushed
the
dl/serializer-codec-versioning
branch
from
September 25, 2026 15:07
83b6a8a to
7d42dbe
Compare
zhenrongliew
added a commit
that referenced
this pull request
Sep 25, 2026
### Summary This is a breaking payload-representation change. Methods are now defined using identity-based IDs, repeated call sites use `method_ref`, and the previous `symbol_table`/mangled-method representation is removed. Payloads containing the old mangled method records are not supported by this decoder. Explicit codec versioning and the policy for rejecting unversioned payloads are separated into the stacked follow-up PR #720 ### Motivation Previously, every call site serialized and reconstructed the complete method wrapper, body already de-duplicated with `region_ref`. On the representative shared-callee benchmark, relative to #713: - JSON: 61,470 → 42,459 bytes (−31%) - CBSON: 5,021 → 4,566 bytes (−9%) - JSON round trip: 4.36 → 2.31 ms (−47%) - CBSON round trip: 6.22 → 4.24 ms (−32%)
…le to use codec versioning
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
zhenrongliew
force-pushed
the
dl/serializer-codec-versioning
branch
from
September 25, 2026 15:13
7d42dbe to
2f86d5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codec_versionto the serialization module.codec_versionas legacy unversioned v1.SerializationModule.versioncaller-controlled and independent from the wire codec.split from original #717 into stacked PR.
This follows the direction discussed in #618.