Repository navigation
fix: keep a valid saved OAuth account in non-interactive mode with several authorized accounts - #711
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
…veral accounts are authorized Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #699
Root cause. In
JsonModule.config_build, the OAuth account handling drops the account saved inlean.jsonwhen it is not in the authorized list or when more than one account is authorized. The second condition exists so interactive runs ask the user to choose again, but it also applied withinteractive=False, where nobody can be prompted. The valid saved account was removed and configuration failed withYou are missing the following option: --<account>.Fix. The "several accounts" rule now applies only in interactive mode. A saved account that is no longer authorized is still discarded in both modes, and an account passed on the command line is untouched.
Tests (
tests/components/util/test_json_modules_handler.py): a valid saved account with several authorized accounts is kept without prompting wheninteractive=False(fails on master with the error above); a saved account that is no longer authorized still raises the missing-option error when non-interactive. The existing interactive tests (prompt on stale account, prompt on several accounts) still pass: 15 passed. Mocked authorization; no live OAuth flow was run.This change was made with Claude Code.
🤖 Generated with Claude Code