chore: upgrade action-translation to v0.16.1#69
Merged
Conversation
review-translations was pinned to v0.13.0 — four releases behind, predating the CRLF fix, so review mode here broke permanently on any PR whose body had been edited. rebase-translations moves from v0.15.0. v0.16.1 fixes, relevant to review and rebase mode here: - review mode: CRLF in the PR body no longer breaks source-PR parsing - review mode: paginate listFiles / listComments — PRs over 30 files were reviewed only in part, and past 30 comments the existing review comment was missed, so duplicates accumulated - rebase mode: paginate pulls.list — sibling PRs beyond 100 were skipped - both: a truncated model response now fails loudly instead of being used See QuantEcon/action-translation#83 and the v0.16.1 release notes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates this repository’s translation automation workflows to use QuantEcon/action-translation@v0.16.1, aligning both review and rebase modes with the latest action release to address known review/rebase reliability issues (CRLF parsing, pagination, truncation detection).
Changes:
- Bump
review-translations.ymlfromv0.13.0tov0.16.1. - Bump
rebase-translations.ymlfromv0.15.0tov0.16.1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/review-translations.yml | Updates the translation review workflow to use action-translation@v0.16.1. |
| .github/workflows/rebase-translations.yml | Updates the translation rebase workflow to use action-translation@v0.16.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| fetch-depth: 2 | ||
|
|
||
| - uses: QuantEcon/action-translation@v0.13.0 | ||
| - uses: QuantEcon/action-translation@v0.16.1 |
| steps: | ||
| - name: Rebase open translation PRs | ||
| uses: QuantEcon/action-translation@v0.15.0 | ||
| uses: QuantEcon/action-translation@v0.16.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings both workflows onto v0.16.1.
review-translations.ymlwas pinned to v0.13.0 — four releases behind, and the most stale pin across all the translation repos. Notably it predates the CRLF fix, which means review mode here has been silently broken for any PR whose body was edited: GitHub normalizes an edited body to CRLF, and the v0.13.0 source-PR parser only matched\n, so it could never find the source PR again.rebase-translations.ymlmoves from v0.15.0.What v0.16.1 fixes for these two modes
listFileswas unpaginated, so a PR touching >30 files was only partly reviewed;listCommentswas too, so past 30 comments the existing review comment wasn't found and duplicates accumulated.pulls.listwas capped at 100, so sibling PRs beyond that were never rebased.max_tokenswas used as if complete; it now fails loudly.The action's translation behaviour on this repo's content was validated before this bump — the 26-scenario e2e harness ran v0.16.1 against
test-translation-sync.zh-cnwith 26/26 correct PRs, graded 9.4/10 translation and 10/10 diff against the December baseline's 9.5 and 10.Detail: QuantEcon/action-translation#83 · v0.16.1 release notes
🤖 Generated with Claude Code