Skip to content

promote: three lectures for the engine-sequencing build tests - #13

Merged
mmcky merged 1 commit into
mainfrom
promote/spike-subset
Oct 5, 2026
Merged

mmcky merged 1 commit into
mainfrom
promote/spike-subset

Conversation

@mmcky

@mmcky mmcky commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

What changes

Three lectures join the pool, promoted with tools/promote networks information_market_equilibrium phillips_drifts_volatilities. They are the three members of the engine-sequencing build-test subset that were not in the pool, and promoting them lets both build tests (Jupyter Book 1 and mystmd) read all eight lectures from the same pool. The subset and the reason for each choice are in research/spikes/ in QuantEcon/project-monorepo; the work item is QuantEcon/project-monorepo#14, and the owner approved the promotion on 2026-10-05.

Lecture Canonical series Pinned at Assets Rewrites Why it is in the subset
networks intro 8a60bd2 5 images under _static/networks/ 5 asset-path rewrites Captioned, named figures referenced by number; labelled theorems
information_market_equilibrium intermediate 0abf403 none none A proof body, lemmas and references to them
phillips_drifts_volatilities intermediate 0abf403 none none Long execution, about 25 minutes on the live site

The pool goes from 49 to 52 lectures. No existing pool file or ledger entry changes; the ledger gains three entries and five asset records.

Checks

tools/drift-check on the branch: 52 pool lectures, 32 assets, "clean: every pool file equals rewrites(canonical) and every recorded copy is where it was."

Worth knowing

  • None of the three is in any product's table of contents yet; the build tests add them to their own test product.
  • phillips_drifts_volatilities fetches data from FRED at run time, so its outputs can vary between runs.

🤖 Generated with Claude Code

networks (canonical intro), information_market_equilibrium and
phillips_drifts_volatilities (canonical intermediate) join the pool, so the
two build tests read every lecture of their subset from the same pool.
Promoted with tools/promote; tools/drift-check is clean at 52 lectures.

See QuantEcon/project-monorepo#14.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 4, 2026 23:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Although the ledger/asset/digest provenance verifies cleanly, the PR introduces three large new lecture files that the build tests will depend on (including one with runtime FRED/network behavior), which warrants a final human glance.

Review effort: Balanced
Findings: None

What changed in this PR

This PR promotes three canonical lectures — networks (from intro), and information_market_equilibrium and phillips_drifts_volatilities (both from intermediate) — into the shared lectures/ pool. These are the three members of the engine-sequencing build-test subset that were not yet pooled, so promoting them lets both build tests read all eight subset lectures from the same pool. The change adds the three verbatim lecture files, five networks image assets, and the corresponding provenance records in sync/ledger.yml.

Changes:

  • Add three pool lecture files, pinned to the series' current sync/state.yml SHAs (intro 8a60bd2, intermediate 0abf403).
  • Add five _static/networks/*.png assets with five _static/lecture_specific/networks/… → _static/networks/… path rewrites recorded for networks.md.
  • Append three lecture ledger entries and five asset ledger records (pool grows 49 → 52 lectures, 32 assets).
File Description
sync/​ledger.yml Adds three lecture provenance entries and five networks asset records (digests, sources, pins, rewrites).
lectures/​networks.md Verbatim intro promotion with asset paths rewritten to the pool's flattened _static/networks/ layout.
lectures/​information_market_equilibrium.md Verbatim intermediate promotion; no assets or rewrites.
lectures/​phillips_drifts_volatilities.md Verbatim intermediate promotion; no assets or rewrites.

I independently verified the mechanical correctness of the promotion rather than reviewing lecture body content, since pool files are intentionally byte-for-byte equal to rewrites(canonical) and a direct pool edit is a drift-check violation:

  • The two no-rewrite lectures' pool digests exactly match their recorded source digests.
  • Reversing the five recorded rewrites on networks.md reproduces the recorded canonical digest ab39506….
  • All five asset files exist and their sha256 digests match the ledger.
  • Pins match sync/state.yml; YAML parses; no duplicate keys; alphabetical ordering preserved; counts (52 lectures / 32 assets) match the PR description and drift-check output.

No actionable issues were found, so I have no review comments to leave.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@mmcky
mmcky merged commit 1243ffe into main Oct 5, 2026
3 checks passed
@mmcky
mmcky deleted the promote/spike-subset branch October 5, 2026 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants