Skip to content

Retire duplicate AIAudit PR reviewer - #100

Merged
Pigbibi merged 8 commits into
mainfrom
codex/aiauditbridge-single-reviewer-cleanup-20260729
Jul 29, 2026
Merged

Retire duplicate AIAudit PR reviewer#100
Pigbibi merged 8 commits into
mainfrom
codex/aiauditbridge-single-reviewer-cleanup-20260729

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • retire the duplicate AIAuditBridge PR-review workflow, script, prompt, policy, and monitoring path
  • keep the GitHub Codex App as the sole AI PR reviewer while preserving deterministic CI, Codex Review Gate, conversation resolution, and branch protection
  • decouple strategy promotion review from the retired script by using the existing AiGatewayClient
  • keep monthly audit/orchestration and guarded monthly-remediation behavior unchanged

The legacy Codex PR Review workflow was disabled before this PR was opened, so this cleanup cannot trigger that reviewer again.

Tests-first evidence

  • new single-reviewer contract test failed on the exact base (2 failed)
  • focused regression: 32 passed, then gateway payload coverage added (6 passed)

Verification

  • python3 -m ruff check .
  • python3 -m pytest tests ops/quant-monitor/tests -q602 passed, 1 skipped, 50 subtests passed
  • actionlint
  • Cloudflare proxy Node tests — 13 passed
  • dashboard Node tests — 15 passed
  • JSON validation and git diff --check

Boundaries

  • no secrets, variables, app/OIDC settings, branch protection, rulesets, VPS, or deploy changes
  • no provider/data/trading/live action

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi

Pigbibi commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@Pigbibi

Pigbibi commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Fail-closed pause: the trusted deterministic gate correctly requires intentional deletion approval from the base branch and a higher one-shot line cap. This PR is being closed temporarily while a separate gate-bootstrap PR adds an exact four-path approval. No gate bypass or protection change will be used; this same PR/branch will be updated from main and reopened afterward.

@Pigbibi Pigbibi closed this Jul 29, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

"request timed out",
"too many active jobs",
)
verdict = VERDICT_UNAVAILABLE if any(marker in message.lower() for marker in unavailable_markers) else VERDICT_INVALID

P2 Badge Preserve unavailable verdicts for transport failures

When the gateway is unreachable due to DNS, connection-refused, TLS, or similar URLError/OSError failures, AiGatewayClient now returns the exception text in an unsuccessful result, but none of these transport errors match this marker list and line 110 classifies them as VERDICT_INVALID. The previous explicit transport-exception handler returned VERDICT_UNAVAILABLE, so service outages are now incorrectly treated as malformed review output; classify gateway transport failures as unavailable.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread service/dual_review_primary.py
Comment thread tests/test_single_pr_reviewer_contract.py
Comment thread service/org_health.py
Pigbibi and others added 2 commits July 29, 2026 11:23
Co-Authored-By: Codex <noreply@openai.com>
…ingle-reviewer-cleanup-20260729

Co-Authored-By: Codex <noreply@openai.com>

# Conflicts:
#	.github/codex_auto_merge_policy.json
@Pigbibi Pigbibi reopened this Jul 29, 2026
@Pigbibi

Pigbibi commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

verdict = VERDICT_UNAVAILABLE if any(marker in message.lower() for marker in unavailable_markers) else VERDICT_INVALID

P2 Badge Preserve unavailable verdicts for transport failures

When the gateway is unreachable because of DNS, TLS, connection-reset, or similar URLError/OSError failures, AiGatewayClient.execute() returns the exception text in an unsuccessful result, but none of these general transport messages match this marker list. They are therefore classified as VERDICT_INVALID, which forces a hard disagreement instead of the intended unavailable/degraded handling; the replaced implementation explicitly classified URLError and OSError as unavailable. Map gateway transport failures to VERDICT_UNAVAILABLE before treating protocol/output errors as invalid.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread service/dual_review_primary.py
Comment thread service/dual_review_primary.py
Pigbibi and others added 4 commits July 29, 2026 11:39
Co-Authored-By: Codex <noreply@openai.com>
…ingle-reviewer-cleanup-20260729

Co-Authored-By: Codex <noreply@openai.com>

# Conflicts:
#	.github/codex_auto_merge_policy.json
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi

Pigbibi commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6c37ff14df

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread service/dual_review_primary.py Outdated
Comment thread service/dual_review_primary.py Outdated
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi

Pigbibi commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: d1fa49c8f2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi
Pigbibi merged commit 2e6c739 into main Jul 29, 2026
6 checks passed
@Pigbibi
Pigbibi deleted the codex/aiauditbridge-single-reviewer-cleanup-20260729 branch July 29, 2026 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant