Retire duplicate AIAudit PR reviewer - #100
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
@codex review |
|
Fail-closed pause: the trusted deterministic gate correctly requires intentional deletion approval from the base branch and a higher one-shot line cap. This PR is being closed temporarily while a separate gate-bootstrap PR adds an exact four-path approval. No gate bypass or protection change will be used; this same PR/branch will be updated from main and reopened afterward. |
There was a problem hiding this comment.
💡 Codex Review
AIAuditBridge/service/dual_review_primary.py
Lines 107 to 110 in 6837229
When the gateway is unreachable due to DNS, connection-refused, TLS, or similar URLError/OSError failures, AiGatewayClient now returns the exception text in an unsuccessful result, but none of these transport errors match this marker list and line 110 classifies them as VERDICT_INVALID. The previous explicit transport-exception handler returned VERDICT_UNAVAILABLE, so service outages are now incorrectly treated as malformed review output; classify gateway transport failures as unavailable.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Codex <noreply@openai.com>
…ingle-reviewer-cleanup-20260729 Co-Authored-By: Codex <noreply@openai.com> # Conflicts: # .github/codex_auto_merge_policy.json
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
AIAuditBridge/service/dual_review_primary.py
Line 110 in cd01cdc
When the gateway is unreachable because of DNS, TLS, connection-reset, or similar URLError/OSError failures, AiGatewayClient.execute() returns the exception text in an unsuccessful result, but none of these general transport messages match this marker list. They are therefore classified as VERDICT_INVALID, which forces a hard disagreement instead of the intended unavailable/degraded handling; the replaced implementation explicitly classified URLError and OSError as unavailable. Map gateway transport failures to VERDICT_UNAVAILABLE before treating protocol/output errors as invalid.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Codex <noreply@openai.com>
…ingle-reviewer-cleanup-20260729 Co-Authored-By: Codex <noreply@openai.com> # Conflicts: # .github/codex_auto_merge_policy.json
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c37ff14df
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Codex <noreply@openai.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Codex Review Gate, conversation resolution, and branch protectionAiGatewayClientThe legacy
Codex PR Reviewworkflow was disabled before this PR was opened, so this cleanup cannot trigger that reviewer again.Tests-first evidence
2 failed)32 passed, then gateway payload coverage added (6 passed)Verification
python3 -m ruff check .python3 -m pytest tests ops/quant-monitor/tests -q—602 passed, 1 skipped, 50 subtests passedactionlint13 passed15 passedgit diff --checkBoundaries