Skip to content

fix: harden runtime scheduling and notifications - #361

Merged
Pigbibi merged 3 commits into
mainfrom
codex/runtime-hardening-ibkr-20260730
Jul 30, 2026
Merged

fix: harden runtime scheduling and notifications#361
Pigbibi merged 3 commits into
mainfrom
codex/runtime-hardening-ibkr-20260730

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • derive heartbeat expectations from configured runtime targets and real exchange sessions instead of a single US-weekday assumption
  • add grace-aware, scoped runtime-report checks so delayed publication does not create false missing-report alerts
  • fail closed on runtime/Telegram delivery errors and preserve the terminal notification outcome for monitoring
  • strengthen runtime-guard diagnostics without changing strategy selection or order decisions

Validation

  • uv sync --locked --extra test
  • uv run --no-sync ruff check --exclude external .
  • uv lock --check
  • PYTHONPATH=. PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --no-sync python -m pytest -q
  • 407 passed, 5 skipped, 6 warnings

Co-Authored-By: Codex <noreply@openai.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 55e730dbed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/runtime_heartbeat_policy.py
Comment thread scripts/runtime_heartbeat_policy.py Outdated
Pigbibi and others added 2 commits July 30, 2026 13:29
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi merged commit d42617f into main Jul 30, 2026
2 checks passed
@Pigbibi
Pigbibi deleted the codex/runtime-hardening-ibkr-20260730 branch July 30, 2026 05:35

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7fcc9d81a8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +118 to +122
(
f"{alias}-scheduler",
f"{alias}-probe-scheduler",
f"{alias}-precheck-scheduler",
)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include warmup jobs in the scheduler filter

When the runtime guard derives its default scheduler pattern, this exact-name whitelist omits the ${cloud_run_service%-service}-warmup-scheduler job created and managed in .github/workflows/sync-cloud-run-env.yml. Consequently, a warmup authentication or dispatch failure that never reaches Cloud Run is filtered out before failure evaluation, allowing the guard to report OK when all other logs are clean; include the warmup job name for each service alias.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant