fix(runtime): block weekend IBKR live schedules - #365
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
CI failure classification: unrelated dependency drift.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85ff885685
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…rce-run-hardening-20260803 Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 846d3fdb8f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5609124b8f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Codex <noreply@openai.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bfb49a069f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33cd90e0e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if timezone != DEFAULT_MARKET_TIMEZONE: | ||
| raise ValueError( | ||
| f"US live account scheduler timezone must be {DEFAULT_MARKET_TIMEZONE}: " | ||
| f"{timezone!r}" |
There was a problem hiding this comment.
When runtime_target.scheduler.timezone is America/New_York but the target explicitly emits IBKR_MARKET_TIMEZONE=Asia/Hong_Kong, this check passes because it examines only the scheduler timezone. The workflow then schedules /run in New York, while runtime_config_support.py:427-430 gives the emitted environment value precedence for the runtime market-open check; consequently, a Friday 15:45 New York invocation is evaluated as Saturday in Hong Kong and skipped, losing the Friday live cycle. The fresh evidence in the final tree is that the canonical-timezone guard still never compares against env_values["IBKR_MARKET_TIMEZONE"]; reject conflicting values or validate both effective timezones.
Useful? React with 👍 / 👎.
1 participant
Summary
IBKR_FORCE_RUNand rejecttruefor live Cloud Run targetsSupersedes #341 with a fresh branch from current
main.Validation
python -m pytest -q tests/test_runtime_config_support.py tests/test_request_handling.py tests/test_cloud_run_entrypoint.py— 136 passedpython -m ruff check scripts/build_cloud_run_env_sync_plan.py tests/test_runtime_config_support.pypython -m compileall -q scripts/build_cloud_run_env_sync_plan.pyactionlint .github/workflows/sync-cloud-run-env.ymlgit diff --checkExisting test issue
bash tests/test_sync_cloud_run_env_workflow.shreaches a pre-existing stale assertion: the test expectssecrets.STRATEGY_PLUGIN_ALERT_TELEGRAM_BOT_TOKEN, while currentmainusessecrets.TG_TOKEN. The assertions changed by this PR pass.