feat(reconciliation): rebuild SOXL non-live static envelope from fresh main - #370
feat(reconciliation): rebuild SOXL non-live static envelope from fresh main#370Pigbibi wants to merge 3 commits into
Conversation
Co-Authored-By: Codex <noreply@openai.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ffea35397
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Codex <noreply@openai.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: efcc9de619
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Codex <noreply@openai.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1afc2a3129
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ("fill",), | ||
| ("fills",), | ||
| ("header",), | ||
| ("headers",), | ||
| ("jwt",), | ||
| ("notional",), | ||
| ("order",), |
There was a problem hiding this comment.
Reject plural runtime order keys
When callers pass the repository's normal execution-summary fields such as orders_submitted, orders_filled, or orders_partially_filled, tokenization yields tokens such as orders and filled, while this denylist only contains the exact tokens order, fill, and fills. The builder therefore accepts material order/fill assertions even though this boundary is intended to reject them and returns an envelope asserting no_order=true; include the plural and inflected forms or normalize them to their forbidden roots.
Useful? React with 👍 / 👎.
| if isinstance(value, (list, tuple)): | ||
| for item in value: | ||
| _reject_non_live_metadata(item) |
There was a problem hiding this comment.
Traverse arbitrary nested metadata containers
When a metadata value uses another standard container such as UserList or deque, recursion stops at this check, so an input such as {"outer": UserList([{"password": "..."}])} is accepted even though the public metadata value type is Any and the same nested dictionary in a list is rejected. This allows credential-bearing metadata to bypass the fail-closed gate based solely on its container type; traverse general non-string containers or explicitly reject unsupported value types.
Useful? React with 👍 / 👎.
|
Closing unmerged and freezing this review loop. SOXL remains negative-learning/non-live/MISSING/no_order. Required CI was green, but consecutive exact-head security/order assertion findings did not close within the one-remediation boundary. Per the anti-review-loop rule, evidence is retained; no further patch, review, merge, or deploy will be performed from this PR. |
Scope
Fresh-main reslice of the closed #369 two-file non-live evidence contract after the exact QPK pin merge/deployment completed.
strategy_profile=soxl_soxx_trend_incomeevidence_scope=NON_LIVE_STATICreconciliation.status=MISSINGlearning_only=true,promotion_eligible=false,live_ready=false,size_zero_required=true,no_order=trueVerification
Boundary
This PR is non-live and must remain open/unmerged pending explicit human merge/deploy authority. It does not establish MATCHED, active, fill, capital, order, paper, shadow, or live authority.