Skip to content

Harden LongBridge runtime errors and notification handling - #340

Merged
Pigbibi merged 1 commit into
mainfrom
codex/fix-runtime-errors-20260728
Jul 29, 2026
Merged

Harden LongBridge runtime errors and notification handling#340
Pigbibi merged 1 commit into
mainfrom
codex/fix-runtime-errors-20260728

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Why

  • Runtime market-hours checks could report a warning even when the provider returned (open, None).
  • Long error tracebacks were sent through compact notification channels, causing noisy or rejected messages.
  • Execution-report persistence needed to tolerate both the current cloud URI result and the legacy GCS URI field.

What changed

  • Emit market-hours warnings only when an actual error is present.
  • Keep detailed tracebacks in durable reports while sending bounded compact notifications.
  • Normalize execution-report persistence return fields across dependency versions.
  • Keep Cloud Run validation routes non-mutating and update compatibility fixtures/regression coverage.

Verification

  • pytest: 287 passed, 1 warning; 15 subtests passed.
  • ruff check: passed for all changed Python files.
  • git diff --check: passed.
  • Codex review (not AIAudit): no actionable findings.

Production safety

  • The credential-refresh persistence permission was repaired separately and the current valid credential was retained.
  • Post-repair service checks were healthy; no live order endpoint was invoked.

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi had a problem deploying to longbridge-paper July 29, 2026 02:23 — with GitHub Actions Failure
@Pigbibi
Pigbibi marked this pull request as ready for review July 29, 2026 02:47
@Pigbibi
Pigbibi merged commit 89e1045 into main Jul 29, 2026
2 of 5 checks passed
@Pigbibi
Pigbibi deleted the codex/fix-runtime-errors-20260728 branch July 29, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant