Skip to content

fix runtime target schedules and notification acknowledgements - #269

Merged
Pigbibi merged 3 commits into
mainfrom
codex/runtime-hardening-qpk-20260730
Jul 30, 2026
Merged

fix runtime target schedules and notification acknowledgements#269
Pigbibi merged 3 commits into
mainfrom
codex/runtime-hardening-qpk-20260730

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • preserve strategy-derived market, calendar, timezone, and scheduler metadata in RuntimeTarget
  • propagate notification delivery acknowledgement through shared ports and cycle publishers
  • reject explicit Telegram API negative acknowledgements and fix the current Telegram channel call contract

Root cause

Runtime consumers could not retain target-specific market scheduling metadata, while notification adapters treated transport calls as fire-and-forget. This allowed stale/missing runs and Telegram ok: false responses to be masked.

Validation

  • PYTHONPATH=src python3 -m pytest -q — 622 passed, 1 skipped
  • Ruff on changed Python files — passed
  • git diff --check — passed

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi marked this pull request as ready for review July 30, 2026 04:00
Co-Authored-By: Codex <noreply@openai.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cd6fa41937

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/quant_platform_kit/common/runtime_target.py
Comment thread src/quant_platform_kit/common/runtime_target.py
Comment thread src/quant_platform_kit/notifications/telegram.py Outdated
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi merged commit 9245859 into main Jul 30, 2026
8 checks passed
@Pigbibi
Pigbibi deleted the codex/runtime-hardening-qpk-20260730 branch July 30, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant