Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis context
sha1org.quantumbadger.redreader.common.Generalsrc/main/java/org/quantumbadger/redreader/common/General.ktMessageDigestSpecfastbotProposed change
Replacing
SHA-1withSHA-256satisfies the verifiedMessageDigestSpecwhile preserving the existing method signature anddigest(byte[])usage. The resulting hexadecimal digest is distinct from the legacy SHA-1 value, so the confirmed derived cache filename becomes a cache miss and is regenerated through the existing cache fallback flow. The unqualifiedgetInstance(String)call continues to allow the platform to select a supporting provider.Compatibility note
This change updates an identifier used only for derived, regenerable cache entries. Existing entries created with the previous identifier may become cache misses and be regenerated. The change is not intended to invalidate user-owned source data, credentials, preferences, or offline-only data. Legacy cache files may remain until the project's normal cache cleanup.
Validation
Additional context
I’m an undergraduate Computer Engineering student at the University of Brasília (UnB), and this contribution is part of a research project involving software security analysis.
I’m happy to adjust the implementation to better match the project’s architecture, coding conventions, or maintainers’ recommendations.
Repository guidance
This contribution was prepared with reference to:
CONTRIBUTING.md