Fix changebonds for FiniteMPS with composite physical spaces - #514
Open
leburgel wants to merge 2 commits into
Open
Fix changebonds for FiniteMPS with composite physical spaces#514leburgel wants to merge 2 commits into
changebonds for FiniteMPS with composite physical spaces#514leburgel wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #494, using the fix @lkdvos suggested there.
I added tests using the one-sided MPO-MPS application that was added for finite temperature support. Unfortunately, these don't pass due to an issue with the corresponding contractions for space types with non-trivial braiding. Changing the space type to
ComplexSpacefixes things, but it's probably better to keep usingPlanarTrivialin the tests`.I reported the issue in QuantumKitHub/BlockTensorKit.jl#68.
Checklist
julia --project=test test/runtests.jl, or the relevant subset)docs/src/)[Unreleased]indocs/src/changelog.md, if this PR is user-facing (new feature, behavior change, bug fix, deprecation, or removal)