Fix broken logging calls in time_evolve - #515
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 67 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lkdvos
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
time_evolvecalled the logging functions with an error set to zero, e.g.loginit!(log, 0, first(t_span)). However, the error is type restricted to aFloat64in theIterativeLoggerssubmodule, leading to a method error. I just added a decimal point to avoid this, and added some non-trivial verbosity in the existingtime_evolvetests to check the effect.