Make svd_trunc pullback GPU friendly - #271
Open
kshyatt wants to merge 1 commit into
Open
Conversation
lkdvos
reviewed
Aug 17, 2026
| AP = mul!(copy(A), US, Vᴴ, -1, 1) | ||
| AP ./= S[end] | ||
| S⁻¹ = S[end] ./ S | ||
| minS = minimum(S) |
Member
There was a problem hiding this comment.
Does last also work? Can we avoid blocking/syncing by using a view of the last element?
Member
Author
There was a problem hiding this comment.
I don't think so 😬 let me try and report back
Member
Author
There was a problem hiding this comment.
I think the problem is any of these require copying the last element back to the CPU, unless we write a custom kernel/map here which I'm kind of loathe to do...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise this hits scalar indexing