Skip to content

Work around GPUArrays change in lq.jl #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kshyatt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Work around GPUArrays change in lq.jl #272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/pullbacks/lq.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,15 @@ function check_and_prepare_lq_cotangents(
if !iszerotangent(ΔQ)
size(ΔQ) == size(Q) || throw(DimensionMismatch("ΔQ must have the same size as Q"))
ΔQ₁ .= view(ΔQ, 1:p, 1:n)
if p == minmn # full rank case, ΔQ₃ contains gauge-invariant information along Q₁
ΔQ₃ = copy(view(ΔQ, (minmn + 1):size(Q, 1), :)) # extra columns in the case of qr_full
Q₃ = view(Q, (minmn + 1):size(Q, 1), :)
Q₃ = view(Q, (minmn + 1):size(Q, 1), :) # extra rows in the case of lq_full
if p == minmn && !isempty(Q₃) # full rank case, ΔQ₃ contains gauge-invariant information along Q₁
ΔQ₃ = copy(view(ΔQ, (minmn + 1):size(Q, 1), :))
ΔQ₃Q₁ᴴ = ΔQ₃ * Q₁'
mul!(ΔQ₃, ΔQ₃Q₁ᴴ, Q₁, -1, 1)
Δgauge_Q = norm(ΔQ₃, Inf)
mul!(ΔQ₁, ΔQ₃Q₁ᴴ', Q₃, -1, 1)
elseif p == minmn
Δgauge_Q = abs(zero(eltype(Q)))
else
ΔQ₂ = view(ΔQ, (p + 1):size(ΔQ, 1), :)
Δgauge_Q = norm(ΔQ₂, Inf)
Expand Down
Loading