[GRDM-62817] Resolve storage providers from project API - #15
Merged
hide24 merged 3 commits intoSep 11, 2026
Merged
Conversation
yacchin1205
marked this pull request as draft
September 11, 2026 01:47
yacchin1205
marked this pull request as ready for review
September 11, 2026 02:51
ShimoyamaT
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Remote paths beginning with
s3compatsigv4/are treated as paths inosfstoragebecause the provider is missing from the fixed provider list.This PR resolves providers from the project's storage API instead, so adding a storage addon no longer requires updating the client-side list. Paths without a connected provider prefix continue to use
osfstorage.Storage enumeration also follows
links.nextinstead of reading only the first page, so providers on later pages can be resolved.Project.storage()uses the same enumeration.Testing
Upload, download, file/folder rename, moves within each storage, recursive upload, listing and deletion were verified on https://rdm.nii.ac.jp/ using S3, S3-compatible storage (SigV4), OSF storage and Google Drive. Downloaded contents matched the originals, and the test data was removed.
Pagination was also tested on the same service with
page[size]=2, confirming thats3compatsigv4could be resolved from the second page.