Skip to content

Publish nightly status.json under nightly/ instead of release-nightly/ - #93

Open
HereThereBeDragons wants to merge 1 commit into
developfrom
users/lpromber/rename_nightly_folder
Open

Publish nightly status.json under nightly/ instead of release-nightly/#93
HereThereBeDragons wants to merge 1 commit into
developfrom
users/lpromber/rename_nightly_folder

Conversation

@HereThereBeDragons

Copy link
Copy Markdown
Collaborator

Nightly status.json files are now published under nightly/ instead of release-nightly/, aligning the directory name with the release_type value of TheRock. This updates the producer, the consumer example, the docs, and the tests. The latest.json / latest_good.json pointers move with it.

The existing release-nightly/ tree is left in place and will be removed in a follow-up PR, so this change is additive on the CI side.

@HereThereBeDragons
HereThereBeDragons requested review from a team, cgoea and marbre September 3, 2026 12:51
@HereThereBeDragons
HereThereBeDragons changed the base branch from main to develop September 3, 2026 12:51

@cgoea cgoea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marbre

marbre commented Sep 7, 2026

Copy link
Copy Markdown
Member

Btw, any way to test this in advance?

@HereThereBeDragons

Copy link
Copy Markdown
Collaborator Author

the unit tests in scripts/receive_therock/tests/therock_update_status_json_test.py and scripts/receive_therock/tests/therock_e2e_smoke_test.py test this.

but yes, we need a pr check to run the unit tests and not just trust people run them locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants