Skip to content

[net/netdev]Fixed compilation errors when enabling IPv6 and IPv4 dual-stack support. - #10691

Merged
Rbb666 merged 1 commit into
RT-Thread:masterfrom
Rbb666:netdev
Sep 15, 2025
Merged

Rbb666 merged 1 commit into
RT-Thread:masterfrom
Rbb666:netdev

Conversation

@Rbb666

@Rbb666 Rbb666 commented Sep 13, 2025

Copy link
Copy Markdown
Member

Fixed compilation errors when enabling IPv6 and IPv4 dual-stack support.

  • 修复使能IPV6和IPV4双栈情况下编译报错问题
  • inet_ntoa 原型已经按照单栈和双栈进行了区分,因此可以简化代码
image image image

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/net/netdev/src/netdev.c

📊 Current Review Status (Last Updated: 2025-09-13 11:33 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@Rbb666
Rbb666 requested a review from supperthomas September 13, 2025 03:33
@Rbb666 Rbb666 mentioned this pull request Sep 12, 2025
8 of 11 tasks
@Rbb666 Rbb666 added the bug This PR/issue is a bug in the current code. label Sep 13, 2025
@Rbb666

Rbb666 commented Sep 13, 2025

Copy link
Copy Markdown
Member Author

@Evlers 大佬,帮忙看看

@Rbb666
Rbb666 merged commit 1e81571 into RT-Thread:master Sep 15, 2025
65 checks passed
@Rbb666 Rbb666 added this to the v5.2.2 milestone Sep 23, 2025
@Rbb666 Rbb666 linked an issue Oct 20, 2025 that may be closed by this pull request
8 of 11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This PR/issue is a bug in the current code. component: net/netdev component: net Component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Utest 测试用例推进事项

2 participants