Skip to content

Revert #11186 - #11191

Merged
Rbb666 merged 1 commit into
masterfrom
revert-11186-master
Feb 10, 2026
Merged

Revert #11186#11191
Rbb666 merged 1 commit into
masterfrom
revert-11186-master

Conversation

@Rbb666

@Rbb666 Rbb666 commented Feb 10, 2026

Copy link
Copy Markdown
Member

Reverts #11186

@github-actions

github-actions Bot commented Feb 10, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：revert-11186-master
  • 设置PR number为 \ Set the PR number to：11191
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 revert-11186-master 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the revert-11186-master branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions Bot added BSP: NXP Code related with NXP BSP labels Feb 10, 2026
@github-actions

github-actions Bot commented Feb 10, 2026

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: bsp_mcxn

Reviewers: @hywing

Changed Files (Click to expand)
  • bsp/nxp/mcx/mcxn/Libraries/drivers/drv_uart.c
  • bsp/nxp/mcx/mcxn/frdm-mcxn947/board/SConscript
  • bsp/nxp/mcx/mcxn/frdm-mcxn947/board/board.c

📊 Current Review Status (Last Updated: 2026-02-10 11:16 CST)

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@Rbb666
Rbb666 merged commit c2103a5 into master Feb 10, 2026
34 of 35 checks passed
ajsb85 added a commit to ajsb85/rt-thread that referenced this pull request Jul 10, 2026
@ajsb85
bsp: mcxn947: fix dead console RX on LPUART
b9c4b82 
LPUART_Init re-ran LP_FLEXCOMM_Init on every configure, resetting the
peripheral and wiping CTRL.RIE set by RT_DEVICE_CTRL_SET_INT, so the
console never received a byte and host-side VCOM writes wedged.

Verified on FRDM-MCXN947 hardware via GDB: NVIC ISER never armed and a
hardware breakpoint on uart_isr never fired until these changes.

- define LPFLEXCOMM_INIT_NOT_USED_IN_DRIVER=1 so fsl drivers stop
  re-initialising the FlexComm on every configure
- select FlexComm function once in rt_hw_flexcomm_mode_init()
- preserve/restore RX interrupt enable across LPUART_Init (PR RT-Thread#11186)
- clear OR/FE/NF/PF in uart_isr: an uncleared overrun inhibits all
  further LPUART reception

Reintroduces the drv_uart.c fix from RT-Thread#11186 (reverted in RT-Thread#11191),
combined with the one-time FlexComm mode selection that makes it safe.

Signed-off-by: Alexander Salas Bastidas <ajsb85@firechip.dev>
@ajsb85 ajsb85 mentioned this pull request Jul 10, 2026
Open
8 of 10 tasks
ajsb85 added a commit to ajsb85/rt-thread that referenced this pull request Jul 10, 2026
@ajsb85
bsp: mcxn947: fix dead console RX on LPUART
f43c08f 
LPUART_Init re-ran LP_FLEXCOMM_Init on every configure, resetting the
peripheral and wiping CTRL.RIE set by RT_DEVICE_CTRL_SET_INT, so the
console never received a byte and host-side VCOM writes wedged.

Verified on FRDM-MCXN947 hardware via GDB: NVIC ISER never armed and a
hardware breakpoint on uart_isr never fired until these changes.

- define LPFLEXCOMM_INIT_NOT_USED_IN_DRIVER=1 so fsl drivers stop
  re-initialising the FlexComm on every configure
- select FlexComm function once in rt_hw_flexcomm_mode_init()
- preserve/restore RX interrupt enable across LPUART_Init (PR RT-Thread#11186)
- clear OR/FE/NF/PF in uart_isr: an uncleared overrun inhibits all
  further LPUART reception

Reintroduces the drv_uart.c fix from RT-Thread#11186 (reverted in RT-Thread#11191),
combined with the one-time FlexComm mode selection that makes it safe.

Signed-off-by: Alexander Salas Bastidas <ajsb85@firechip.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@supperthomas supperthomas supperthomas approved these changes

Assignees

No one assigned

Labels

BSP: NXP Code related with NXP BSP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Rbb666 @supperthomas