Skip to content

[bsp][loongson] Clamp CAN receive DLC - #11706

Merged
Rbb666 merged 1 commit into
RT-Thread:masterfrom
RogerNext:agent/fix-ls1c-can-dlc-oob
Aug 14, 2026
Merged

Rbb666 merged 1 commit into
RT-Thread:masterfrom
RogerNext:agent/fix-ls1c-can-dlc-oob

Conversation

@RogerNext

Copy link
Copy Markdown
Contributor

拉取/合并请求描述:(PR description)

为什么提交这份PR (why to submit this PR)

The ls1c CAN receive path uses the raw 4-bit hardware DLC as the copy length. A malformed frame with DLC 9-15 therefore writes past the 8-byte classic CAN data buffer.

Fixes #11424.

你的解决方案是什么 (what is your solution)

Clamp the received DLC to the capacity of the hardware receive data array and use the clamped value when copying the payload. Valid classic CAN frames with DLC 0-8 are unchanged.

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp/loongson/ls1cdev
  • .config: No configuration changes.
  • action: Pending upstream PR CI. The local environment does not provide the mips-sde-elf cross compiler. A host boundary harness covering DLC 0-15 passed with -Wall -Wextra -Werror, and git diff --check passed.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用clang-format 源码格式化工具确保格式符合RT-Thread代码规范 This PR has been formatted with clang-format and complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@CLAassistant

CLAassistant commented Aug 13, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • Use workflow from 保持默认分支(通常为 master)
    Keep the default branch (usually master) in Use workflow from
  • 在 branch 输入框填写 PR 分支 agent/fix-ls1c-can-dlc-oob
    Enter PR branch agent/fix-ls1c-can-dlc-oob in the branch field
  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将作为独立提交推送至你的分支。
    The formatting changes will be pushed to your branch as a separate commit.

完成后,提交将自动更新至 agent/fix-ls1c-can-dlc-oob 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the agent/fix-ls1c-can-dlc-oob branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions Bot added BSP: Loongson BSP related with Loongson BSP labels Aug 13, 2026
@github-actions

Copy link
Copy Markdown

MemBrowse Memory Report

No memory changes detected for:

@Rbb666
Rbb666 merged commit 0c1a9a4 into RT-Thread:master Aug 14, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: Loongson BSP related with Loongson BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Security-related Bug: ls1c CAN receive path trusts raw DLC and writes past rt_can_msg data

3 participants