Skip to content

[BSP][STM32] Adapt Ethernet driver to new HAL API - #11781

Merged
Rbb666 merged 1 commit into
RT-Thread:masterfrom
CYFS3:stm32-eth-new-hal
Sep 15, 2026
Merged

Rbb666 merged 1 commit into
RT-Thread:masterfrom
CYFS3:stm32-eth-new-hal

Conversation

@CYFS3

@CYFS3 CYFS3 commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

适配stm32以太网的新版api
已在f4和h7平台验证
f4:
image

h7:
image

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用clang-format 源码格式化工具确保格式符合RT-Thread代码规范 This PR has been formatted with clang-format and complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@CYFS3
CYFS3 requested a review from Rbb666 as a code owner September 6, 2026 07:17
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • Use workflow from 保持默认分支(通常为 master)
    Keep the default branch (usually master) in Use workflow from
  • 在 branch 输入框填写 PR 分支 stm32-eth-new-hal
    Enter PR branch stm32-eth-new-hal in the branch field
  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将作为独立提交推送至你的分支。
    The formatting changes will be pushed to your branch as a separate commit.

完成后,提交将自动更新至 stm32-eth-new-hal 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the stm32-eth-new-hal branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions Bot added BSP: STM32 BSP related with ST/STM32 BSP labels Sep 6, 2026
@github-actions

github-actions Bot commented Sep 6, 2026 •

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

Reviewers: @Liang1795 @hamburger-os @wdfk-prog

Changed Files (Click to expand)
  • bsp/stm32/libraries/HAL_Drivers/drivers/SConscript
  • bsp/stm32/libraries/HAL_Drivers/drivers/drv_eth.c
  • bsp/stm32/stm32f407-atk-explorer/board/CubeMX_Config/Inc/stm32f4xx_hal_conf.h
  • bsp/stm32/stm32f407-atk-explorer/board/Kconfig
  • bsp/stm32/stm32h750-artpi/board/CubeMX_Config/Core/Inc/stm32h7xx_hal_conf.h
  • bsp/stm32/stm32h750-artpi/board/Kconfig
  • bsp/stm32/stm32h750-artpi/board/port/SConscript
  • bsp/stm32/stm32h750-artpi/board/port/drv_eth.c

🏷️ Tag: bsp_stm32h750-artpi

Reviewers: @LittleGreyG

Changed Files (Click to expand)
  • bsp/stm32/stm32h750-artpi/board/CubeMX_Config/Core/Inc/stm32h7xx_hal_conf.h
  • bsp/stm32/stm32h750-artpi/board/Kconfig
  • bsp/stm32/stm32h750-artpi/board/port/SConscript
  • bsp/stm32/stm32h750-artpi/board/port/drv_eth.c

📊 Current Review Status (Last Updated: 2026-09-08 23:25 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions

github-actions Bot commented Sep 6, 2026 •

Copy link
Copy Markdown

MemBrowse Memory Report

No memory changes detected for:

@Rbb666

Rbb666 commented Sep 7, 2026 •

Copy link
Copy Markdown
Member

ci有个报错,需要解决下

@CYFS3

CYFS3 commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor Author

ci有个报错,需要解决下

需要合并 RT-Thread-packages/stm32h7xx-hal-driver#2

@Rbb666 Rbb666 closed this Sep 8, 2026
@Rbb666 Rbb666 reopened this Sep 8, 2026
@CYFS3
CYFS3 force-pushed the stm32-eth-new-hal branch from 3aad24a to 23a2f22 Compare September 8, 2026 15:16
@CYFS3
CYFS3 force-pushed the stm32-eth-new-hal branch 2 times, most recently from 43a09d0 to df79dce Compare September 8, 2026 15:25
@CYFS3

CYFS3 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

ci有个报错,需要解决下

已解决

@Rbb666
Rbb666 merged commit f165a0f into RT-Thread:master Sep 15, 2026
33 of 45 checks passed
@CYFS3
CYFS3 deleted the stm32-eth-new-hal branch September 21, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: STM32 BSP related with ST/STM32 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants