Skip to content

[drivers][virtio] Reject invalid input offsets without overflow #11826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manyangshen wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[drivers][virtio] Reject invalid input offsets without overflow #11826

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ed72eb
[drivers][virtio] Validate input offsets without range-check overflow
manyangshen Sep 23, 2026
252fe1e
[drivers][virtio] Check input offsets before the remaining range
manyangshen Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions components/legacy/virtio/virtio_input.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,10 @@ static rt_err_t virtio_input_init(rt_device_t dev)
static rt_ssize_t virtio_input_read(rt_device_t dev, rt_off_t pos, void *buffer, rt_size_t size)
{
struct virtio_input_device *virtio_input_dev = (struct virtio_input_device *)dev;
rt_size_t queue_size = virtio_input_dev->virtio_dev.queues[VIRTIO_INPUT_QUEUE_EVENT].num;

if (buffer == RT_NULL || pos + size >= virtio_input_dev->virtio_dev.queues[VIRTIO_INPUT_QUEUE_EVENT].num)
if (buffer == RT_NULL || pos < 0 || (rt_size_t)pos >= queue_size ||
size >= queue_size - (rt_size_t)pos)
{
return 0;
}
Expand All @@ -160,8 +162,10 @@ static rt_ssize_t virtio_input_read(rt_device_t dev, rt_off_t pos, void *buffer,
static rt_ssize_t virtio_input_write(rt_device_t dev, rt_off_t pos, const void *buffer, rt_size_t size)
{
struct virtio_input_device *virtio_input_dev = (struct virtio_input_device *)dev;
rt_size_t queue_size = virtio_input_dev->virtio_dev.queues[VIRTIO_INPUT_QUEUE_EVENT].num;

if (buffer == RT_NULL || pos + size >= virtio_input_dev->virtio_dev.queues[VIRTIO_INPUT_QUEUE_EVENT].num)
if (buffer == RT_NULL || pos < 0 || (rt_size_t)pos >= queue_size ||
size >= queue_size - (rt_size_t)pos)
{
return 0;
}
Expand Down
Loading