Repository navigation
Conversation
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
📌 Code Review Assignment🏷️ Tag: workflowReviewers: @Rbb666 @kurisaW @supperthomas Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2026-10-24 19:08 CST)
📝 Review Instructions
|
|
| results = monitor_workflows(github_token, repo, workflows, start_time) | ||
|
|
||
| with open("monitoring_results.json", "w") as f: | ||
| with open("monitoring_results.json", "w", encoding="utf-8") as f: | ||
| json.dump(results, f, indent=2) |
There was a problem hiding this comment.
结果文件要等全部监控完才写(2×120min 贴着 270min 超时),中途被杀整份报告都丢;建议每监控完一个就落盘。
| return | ||
|
|
||
| failed_workflows = [r for r in results if r.get('conclusion') == 'failure'] | ||
| failed_workflows = [r for r in results if r.get('conclusion') != 'success'] |
There was a problem hiding this comment.
非 success 已计入,但只对 failure 拉 jobs,cancelled 等几乎没详情。
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
每日 CI 的监控窗口只有 30 分钟,超时、取消、未找到运行等结果未被完整计入失败;监控脚本仍可能以成功退出,且失败后的报告步骤会被跳过。查找不到本轮运行时还会回退到历史记录,失败作业列表也可能因未分页而遗漏。
月度 BSP 构建仍使用已停用的 upload-artifact@v3,定时触发时缺少手动输入默认值,且 BSP 编译失败清单未反映到工作流退出状态。
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up