Repository navigation
Use hash of test files instead of unique ID - #102
Merged
Merged
Conversation
SimonRit
approved these changes
Sep 28, 2026
SimonRit
left a comment
SimonRit
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. I suppose the failing Python test is not caused by this PR?
Unique ID does not change when content of file changes, unlike the hash. Using the hash is more robust as it allows several versions or branches of PCT to use their own test files.
acoussat
force-pushed
the
test-files-hash
branch
from
October 5, 2026 09:53
68eba29 to
b03ea01
Compare
SimonRit
approved these changes
Oct 5, 2026
Collaborator
Author
It was, I had completely messed up the test data last week. I fixed it now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unique ID does not change when content of file changes, unlike the hash. Using the hash is more robust as it allows several versions or branches of PCT to use their own test files.