Repository navigation
--store-time test - #104
Merged
Merged
Conversation
The previous set of tests did not catch that pctpairprotons was not compatible with the current stable version of GATE. This simple test ensures that the correct timing branch is used by pctpairprotons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--store-timeoption ofpctpairprotonsdoes not use the same timing information ROOT branch as GATE 10.1.1 (see #103). This PR fixes the branch and add a test to check that the correct branch is actually being used. Once the next version of GATE is released, the branch will have to be updated.
The PR appears safe to merge for its stated GATE 10.1.1 target.Summary
Changes
pctpairprotons --store-timeto readLocalTimefor GATE 10.1.1.LocalTimebranch.Acknowledgment: acoussat states that the next GATE release will require another timing-branch update. That known compatibility limit is not reported as a new issue.
Reviews (1) · Last reviewed commit: "ENH: Add test for pctpairprotons --store..." · Reviewed by Greptile