Repository navigation
Require uproot version above 5.7.5 - #106
Merged
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
SimonRit
approved these changes
Oct 19, 2026
SimonRit
left a comment
SimonRit
left a comment
Collaborator
There was a problem hiding this comment.
I let you merge when greptile is happy.
acoussat
force-pushed
the
uproot-version
branch
from
October 19, 2026 12:46
3fcb3d1 to
52c583f
Compare
The value returned by the arrays method of uproot changed its type starting from uproot 5.7.5. Because of that, some tests such as pct_application_test::test_addnoise_application were failing in some environment, such as the one running on the CI. To simplify the code, uproot>=5.7.5 is now required. This also clarifies the relatied comment in the code of pctpairprotons.
acoussat
force-pushed
the
uproot-version
branch
from
October 20, 2026 16:10
52c583f to
241a8fb
Compare
acoussat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value returned by the arrays method of uproot changed its type starting from uproot 5.7.5. Because of that, some tests such as
pct_application_test::test_addnoise_applicationwere failing in some environment, such as the one running on the CI (for instance: https://github.com/RTKConsortium/PCT/actions/runs/39214133330/job/117961557622?pr=99). To simplify the code, uproot >= 5.7.5 is now required.
The PR appears safe to merge.Summary
Raises the test dependency minimum to
uproot >= 5.7.5and compares ROOT output one branch at a time.Reviews (3) · Last reviewed commit: "ENH: Require uproot version above 5.7.5" · Reviewed by Greptile