Skip to content

Fix intermittent failure in test_known_telescopes - #1697

Merged
bhazelton merged 1 commit into
mainfrom
fix_known_telescopes_test
Aug 18, 2026
Merged

Fix intermittent failure in test_known_telescopes#1697
bhazelton merged 1 commit into
mainfrom
fix_known_telescopes_test

Conversation

@kartographer

@kartographer kartographer commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes an issue w/ test_known_telescopes, where some downloading issues appear to have caused a race condition (causing some CIs to fail).

Motivation and Context

Trying to avoid CI jobs failing b/c of flaky tests....

(also, apparently if you tell an AI agent to draft a PR, it'll just generate and push the whole thing without asking, oy!)

Types of changes

  • Build or continuous integration change

Checklist:

Build or continuous integration change checklist:

  • If required or optional dependencies have changed (including version numbers), I have updated the readme, pyproject.toml, environment.yaml and CI conda yaml files to reflect the changes.

@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.93%. Comparing base (18f4f6a) to head (6e632cf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1697   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          67       67           
  Lines       22982    22982           
=======================================
  Hits        22968    22968           
  Misses         14       14           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bhazelton bhazelton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. It's possible this is now happening because of a change I made in #1685 -- now on newer versions of astropy we shouldn't need to refresh the cache every time. If we continue to have trouble we can revisit that change...

@bhazelton
bhazelton merged commit 840dd06 into main Aug 18, 2026
91 of 97 checks passed
@bhazelton
bhazelton deleted the fix_known_telescopes_test branch August 18, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants