Fix intermittent failure in test_known_telescopes - #1697
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1697 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 67 67
Lines 22982 22982
=======================================
Hits 22968 22968
Misses 14 14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bhazelton
approved these changes
Aug 18, 2026
bhazelton
left a comment
Member
There was a problem hiding this comment.
Looks reasonable. It's possible this is now happening because of a change I made in #1685 -- now on newer versions of astropy we shouldn't need to refresh the cache every time. If we continue to have trouble we can revisit that change...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue w/
test_known_telescopes, where some downloading issues appear to have caused a race condition (causing some CIs to fail).Motivation and Context
Trying to avoid CI jobs failing b/c of flaky tests....
(also, apparently if you tell an AI agent to draft a PR, it'll just generate and push the whole thing without asking, oy!)
Types of changes
Checklist:
Build or continuous integration change checklist: