Repository navigation
Conversation
|
Review changes with Changed Files
|
Contributor
|
Closed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
With Angular 22, just using
protected some_flag = falseand updating in in the .js won't get those changes reflected into the painted UI. Instead, we need signals.I first wrote all these changes after doing the upgrade to Angular 22 -- see #618 -- but I want to splice them into their own PR for cleaner reviewing, so this is what this PR is: put together all conversions to signals.
Fixes?
Make the code work with signals in anticipation of Angular 22 conversion.
Feedback sought?
Careful review of the code, as well as testing.
Priority?
low
Tests added?
well covered by CI, thankfully, which helped me detect all these issues.
How to test?
Play with the GUI, make sure everything still works. It might be worth testing both this PR's preview, which is still on Angular 21, as well as #618's PR preview, which contain the same GUI signal changes but on Angular 22.
Confidence?
pretty decent now, thanks @deltork for helping me get the last issue fixed!
Version change?
not this PR, but the whole Angular 22 conversion stack will warrant a patch bump.