Fix: add retry logic in 4.15 - #2793
Conversation
Signed-off-by: Adam Cinko <acinko@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Cherry-pick Operations
Branch Management
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
|
omrirh can not be added as reviewer. Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the RedHatQE/openshift-python-wrapper repository.: 422 {"message": "Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the RedHatQE/openshift-python-wrapper repository.", "documentation_url": "https://docs.github.com/rest/pulls/review-requests#request-reviewers-for-a-pull-request", "status": "422"} |
PR Summary by QodoBackport transient API request retries to 4.15
AI Description
Diagram
High-Level Assessment
Files changed (5)
|
|
oharan2 can not be added as reviewer. Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the RedHatQE/openshift-python-wrapper repository.: 422 {"message": "Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the RedHatQE/openshift-python-wrapper repository.", "documentation_url": "https://docs.github.com/rest/pulls/review-requests#request-reviewers-for-a-pull-request", "status": "422"} |
Code Review by Qodo
1.
|
Address PR review feedback: - Add type annotations to retry_cluster_exceptions, api_request, and VM/VMI api_request overrides (matching v4.16 signatures) - Add from __future__ import annotations for Python 3.8+ compat - Fix flake8 FCN001: use object.__new__() and keyword args in tests - Add type hints to all test methods and helpers Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
omrirh can not be added as reviewer. Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the RedHatQE/openshift-python-wrapper repository.: 422 {"message": "Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the RedHatQE/openshift-python-wrapper repository.", "documentation_url": "https://docs.github.com/rest/pulls/review-requests#request-reviewers-for-a-pull-request", "status": "422"} |
|
oharan2 can not be added as reviewer. Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the RedHatQE/openshift-python-wrapper repository.: 422 {"message": "Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the RedHatQE/openshift-python-wrapper repository.", "documentation_url": "https://docs.github.com/rest/pulls/review-requests#request-reviewers-for-a-pull-request", "status": "422"} |
| from ocp_resources.virtual_machine_instance import VirtualMachineInstance | ||
|
|
||
|
|
||
| class TestApiRequestRetry: |
There was a problem hiding this comment.
please remove this unitest, this is old branch.
considare adding this to main instead.
Short description:
Adds API call retry logic back into 4.15 wrapper.
More details:
In the gating report mentioned below, I added retry logic from 4.16 back into 4.15 to improve the test stability.
What this PR does / why we need it:
Failing Gating tests due to 5xx code error. Because there's no retry logic, the API call isn't re-attempted after failing. The re-attempt could make the error go away since it's of the 5xx variety (server side).
Which issue(s) this PR fixes:
https://redhat.atlassian.net/browse/CNV-86678
Special notes for reviewer:
Co-Authored: Opus 4.8 noreply@anthropic.com
Bug: