Repository navigation
fix(release): releases are built from a clean tree and say which file is not - #14
Merged
Merged
Conversation
… is not v1.3.0 was released marked DIRTY-TREE with no clue why. And the patch version step added in #13 wrote the computed version into mac-app/VERSION, which would have marked every later release dirty too. - build-app and make-dmg take the version from CM_RELEASE_VERSION when set; the workflow passes it instead of rewriting VERSION. - build-app lists the uncommitted paths when the tree is dirty, and the workflow prints `git status` before building. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
swift-argument-parser 1.8.2 (pinned in Package.resolved) needs Swift 6. The macos-14 runner has Swift 5.10, so it quietly resolved 1.7.2 and rewrote Package.resolved: CI tested, and v1.3.0 shipped, a different dependency than the repository pins - which is what the DIRTY-TREE marker was saying. CI and releases now run on macos-15 (Swift 6), with the runner's default Xcode, not a pinned one. A release also stops if the build changed any tracked file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…Xcode 16 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: v1.3.0 was released marked
DIRTY-TREE, and the log does not say why. Worse, the version step added in #13 wrote the computed version intomac-app/VERSION, so every later release would have been marked dirty too.What changes:
build-appandmake-dmgreadCM_RELEASE_VERSION, which the workflow passes instead of rewritingVERSION.build-applists the changed files, and the workflow printsgit statusbefore the build. The dry run on this PR already shows whether a runner step changes something.Note: merging this PR will release 1.3.1 automatically, because it touches
mac-app/Sources. That is also the test that the fix works.🤖 Generated with Claude Code