Remove LoadMusicStreamFromPhysFS - #61
Merged
Merged
Conversation
Owner
Author
|
fix conflict |
RobLoach
commented
Jul 29, 2026
| * | ||
| * @internal | ||
| */ | ||
| typedef struct PhysFSMusicFileData { |
Owner
Author
There was a problem hiding this comment.
Is there a way to avoid the static variables, and implementing the PhysFSMusicFileData struct? Maybe copy the memory inside?
RobLoach
marked this pull request as draft
July 29, 2026 18:39
RobLoach
marked this pull request as ready for review
July 31, 2026 03:16
RobLoach
force-pushed
the
fix/58-loadmusicstreamfromphysfs-leaks
branch
from
August 1, 2026 16:12
29d2cac to
2876f1e
Compare
RobLoach
changed the title
RobLoach
changed the title
RobLoach
commented
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes LoadMusicStreamFromPhysFS, which leaked the file buffer by design since raylib streams music from caller-owned memory; the README, example, and tests now show the supported pattern of LoadFileDataFromPhysFS + LoadMusicStreamFromMemory with UnloadFileData after UnloadMusicStream. Fixes #58