Repository navigation
切换 SOP 时保留未保存的节点编辑 - #14
Open
Robert0622 wants to merge 3 commits into
Open
Robert0622 wants to merge 3 commits into
Robert0622 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
复现与影响
在流程设计器里把第一个 SOP 的节点改为「尚未保存的核对步骤」,随后从全局搜索打开另一个 SOP。原版立即更换画布,当前修改丢失。模板列表也会直接用库里的版本覆盖正在编辑的流程,包括重新打开同一个 SOP 的情况。
修改
全局搜索、项目卡片、通用模板编辑、设计器切换器和地址栏导航共用切换逻辑。选择当前流程保留草稿。切换至不同流程时,「继续编辑」保留修改,「放弃修改并切换」才载入目标和重置撤销记录。浏览器导航改变后,过期的确认结果不会替用户打开旧目标。
实测
在同一套 MySQL 临时安装里创建两条真实项目流程。对照下图,修复后同一步操作停留在原流程并出现确认。实际点击了继续编辑、重新打开原流程和放弃修改,随后从模板列表和地址栏重复验证。重新读取数据库,放弃的节点名未被意外写入。流程编辑器与应用外壳回归通过。
Closes #11
另运行了项目已有的卡片菜单独立测试,以及使用真实切换逻辑的编辑器测试,涵盖菜单关闭与草稿确认。
组合部署回归
按 v0.4.0 合并八个待审 PR 后再次在隔离 MySQL 部署复验。管理员与普通成员在 320、375、768、1280 CSS 像素下共 86 组页面访问均抵达目标页面。Chromium 源码套件 22 项常规场景通过,另两项分别使用仓库凭据与指定模型完成条件补测。
当前提交的 CI
提交
f6f30df4ebab的 15 项 GitHub 检查全部通过,含 macOS。 查看检查记录