chore(sdk): regenerate; report downloads default to the Tavi - #220
Conversation
The backend retired the flat JSON-LD download and the JSONLD value of ReportDownloadFormat; a published report's anchor is now the Tavi model. LedgerClient.download_report_bundle defaults to "tavi" and no longer accepts "jsonld", the GetLedgerReportDownloadUrl operation defaults to TAVI, and the SDK and typed GraphQL models are regenerated against the current API.
|
@claude please review this PR |
|
Claude finished @jfrench9's task in 1m 36s —— View job Reviewing PR #220
PR SummaryTitle: chore(sdk): regenerate; report downloads default to the Tavi Regenerates the SDK against the current API. CompatibilityBREAKING (by decision), correctly scoped and disclosed. A caller of Verification
My ReviewIssues (should fix before merge)None found. Suggestions (non-blocking)
QuestionsNone — the compatibility section in the PR description already covers the one behavioral break clearly and calls out the release-notes obligation. VerdictAPPROVE. Clean, well-scoped regeneration; the one intentional breaking change (Tavi as default download format) is correctly implemented across the facade, GraphQL operation, generated code, and tests, and is clearly disclosed in the PR description. |
Summary
Regenerates the SDK against the current API and moves report downloads to the Tavi default. The backend retired the flat JSON-LD download and the
JSONLDvalue ofReportDownloadFormat(RoboFinSystems/robosystems#1514); a published report's anchor artifact is now the Tavi compiled model.LedgerClient.download_report_bundledefaulted to"jsonld", so it moves to"tavi"in the same release.Changes
Facade (
clients/ledger_client.py)download_report_bundledefaultsformatto"tavi"."jsonld"is removed from_DOWNLOAD_FORMAT_ALIASES, and the docstring liststavi/holon-jsonld/xbrl-2.1.tavi.json.GraphQL
operations/ledger/GetLedgerReportDownloadUrl.graphqldefaults$formattoTAVI.schema.graphqlis refreshed from the running backend, and the typed models are regenerated (just generate-graphql):ReportDownloadFormat.JSONLDis gone fromgenerated/enums.py.OpenAPI regen (
api/,models/), drift from backend changes already on main:regenerate_mfa_recovery_codes,delete_user_passkeyandget_passkey_reauth_optionsacceptAuthenticatedClient | Client.ExecuteEventBlockResponsegains an optionalqb_entry_idsfield (new modelExecuteEventBlockResponseQbEntryIdsType0).Compatibility
MINOR, by decision. It's ADDITIVE except for one retired value:
download_report_bundle(..., format="jsonld")is no longer accepted, because the server no longer serves the flat JSON-LD. A call that passed no format now returns the Tavi instead of the flat JSON-LD.taviformat has been served since 2026-09-06, so this release works against the current production API, ahead of refactor(reports): anchor publish on the Tavi model, retire the flat JSON-LD robosystems#1514's deploy.Testing
just test-all: 591 passed, 17 skipped; ruff, format and basedpyright clean.TAVIin the GraphQL variables, a.tavi.jsonfilename, andformat == "tavi".just generate-graphqlregenerates cleanly against the refreshed schema.🤖 Generated with Claude Code