fix(files): report the status code when ingest-file fails - #225
Merged
Merged
Conversation
A failed ingest returned "Failed to complete file upload" with no status, while a failed upload-URL request already reports its code. Callers that retry on a 429 could not tell a rate-limited ingest from any other failure, so a rate-limited load failed instead of backing off. Claude-Session: https://claude.ai/code/session_018kncpCo1113kH9HrBC8GYy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileClient.uploadnow returnsFailed to complete file upload: <status>when the ingest step fails, matching the upload-URL failure (Failed to get upload URL: <status>).ingest-file, and the caller's 429 retry never fired.Tier
Stable tier (
FileClientfacade): only the error string changes, adding the status after the existing prefix. Callers that check"Failed to complete file upload" in errorkeep matching. Patch release.Test plan
just test-all: 595 passed, 17 skipped; lint, format and typecheck cleantest_upload_update_failsnow asserts the exact message, including the status🤖 Generated with Claude Code