docs(claude): correct the empty-conversation guard to its two-case form [skip-ci] - #880
Merged
Merged
Conversation
…rm [skip-ci] The session-lifecycle bullet still described the guard as `promptCount === 0`, which #878 replaced. As written it asserted that any prompted session with no transcript is data loss and 404s — now true only past the watcher's deadline, and the exact reasoning that left the original hole open. Records both disjoint cases, why the second exists, and why recency is anchored on `lastActivityAt ?? startedAt` rather than the spawn.
RonenMars
force-pushed
the
docs/conversation-pending-404
branch
from
September 12, 2026 06:55
28dac13 to
3e41cc6
Compare
Owner
Author
|
🎉 This PR is included in version 1.90.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #878, which changed the behaviour this bullet describes.
What was stale
The session-lifecycle bullet still documented the guard as
promptCount === 0:Both halves are now wrong in a way that matters.
The counter is no longer the whole test, and the closing sentence asserts flatly that a prompted session with no transcript is data loss — true only past the watcher's deadline since #878.
That sentence is worth more than a routine doc correction, because it is the precise reasoning that left the hole open in the first place: it reads as a deliberate, closed decision, so the next reader has no reason to ask whether "has sent prompts" and "has a transcript" can ever be true at different instants.
They can, for 0.3s–1.7s, every single time a session is first prompted.
What it says now
promptCount === 0qualifies indefinitely (an abandoned session never gets a file); a prompted session qualifies only while the transcript is in flight.pty.input_write→ 404 →session.jsonl_wired.lastActivityAt ?? startedAtand not the spawn — spawn-to-first-prompt ran to 405.7s, so a spawn anchor reopens the hole for anyone slow to type.Scope
Docs only — one bullet in
CLAUDE.md, nothing else touched, hence[skip-ci].No version is cut:
docs:is not a releasing type, somainmoves once rather than twice.