Skip to content

[Fix] Keep the Fast transcript's working indicator up until the turn ends #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrubens wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[Fix] Keep the Fast transcript's working indicator up until the turn ends #2039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 79 additions & 0 deletions apps/web/src/app/(sandbox)/sessions/[sessionId]/FastSessionTranscript.client.test.tsx
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 8 additions & 6 deletions apps/web/src/app/(sandbox)/sessions/[sessionId]/FastSessionTranscript.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,12 +192,12 @@ export function pendingResponseReducer(
};
}

function ThinkingMessage() {
function ThinkingMessage({ label = 'Thinking' }: { label?: string }) {
return (
<Message from="assistant" className="chat-reasoning-message">
<MessageContent>
<Shimmer className="text-sm font-light" direction="rl" duration={1}>
Thinking
{label}
</Shimmer>
</MessageContent>
</Message>
Expand Down Expand Up @@ -602,10 +602,12 @@ export function FastSessionTranscript({
/>
{pendingResponseState.pendingAfter !== null ? (
<ThinkingMessage />
) : !isSending &&
conversationResponding !== true &&
runningTaskCount > 0 &&
openTasksPanel ? (
) : conversationResponding === true ? (
// Visible output (a tool call, an acknowledgement) has arrived
// but the turn is still running: the responding lease is the
// authority, and it clears the moment the closeout lands.
<ThinkingMessage label="Working" />
) : !isSending && runningTaskCount > 0 && openTasksPanel ? (
<RunningTasksMessage
count={runningTaskCount}
onOpenTasks={openTasksPanel}
Expand Down
Loading