[Fix] PR screenshots disappear when proof completion races timeout - #2090
Open
roomote-roomote[bot] wants to merge 9 commits into
Open
[Fix] PR screenshots disappear when proof completion races timeout#2090roomote-roomote[bot] wants to merge 9 commits into
roomote-roomote[bot] wants to merge 9 commits into
Conversation
Contributor
|
No code issues found. See task
Reviewed d02fabc |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 2, 2026 21:03
…al-proof-artifacts
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
The five-minute visual-proof deadline can interrupt the active capture turn after screenshots upload but before its result is retained. Without durable attempt identity and complete lifecycle cleanup, those uploads are indistinguishable from artifacts produced by an earlier, cancelled, terminally failed, or wedged proof cycle.
Impact
PR delivery can recover screenshots after a lost capture result without attaching stale artifacts. The implementation is aligned with the direct-capture architecture introduced by #2091; the obsolete hidden proof-runner files remain deleted. Raw skill instructions construct paths from the actual
attemptIdvalue and contain no encoded or literal angle-bracket placeholders. The full worker suite passes 1,838 tests, including the previously failing timeout case; focused workflow tests, package type checks, worker lint, formatting, merge validation, and repository pre-push checks also pass. Browser proof is not applicable to this hidden orchestration behavior.