[Fix] Fast parent events repeatedly retry exhausted OpenRouter accounts - #2128
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Fix] Fast parent events repeatedly retry exhausted OpenRouter accounts#2128roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
| await markDiscarded(row.id, deliveryError); | ||
| continue; | ||
| } | ||
| if (isNonRetryableFastAgentInferenceError(error)) { |
Contributor
There was a problem hiding this comment.
deliverFastAgentParentEventWithLock wraps failures from answerFastAgentQuestion in FastAgentParentEventDeliveryError before they reach this catch block (fast-agent-parent-event.ts:1862). The new predicate only accepts a direct FastAgentInferenceError, so it returns false for this wrapper and the row is left pending and retried by recovery. Inspect the error cause (or unwrap it here) so an OpenRouter credit failure is actually discarded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
limit_source=openrouter_credits) and stop both OpenCode and Fast inference retries immediately.Why this change was made
Fast parent platform events could exhaust their bounded inference and BullMQ retries after an OpenRouter account-credit failure, then be recreated every minute because the durable PostgreSQL event remained pending. That turned a terminal account condition into an unbounded production retry storm.
Impact
Explicit OpenRouter credit-limit failures now settle once at the inference and durable queue boundaries. Temporary provider outages, rate limits, unknown 402 responses, and missing OpenCode sessions retain their recovery behavior.