Skip to content

[Fix] Task deletion no longer leaks artifacts after storage failures - #2186

Open
roomote-roomote[bot] wants to merge 1 commit into
developfrom
fix/task-artifact-delete-failures
Open

[Fix] Task deletion no longer leaks artifacts after storage failures#2186
roomote-roomote[bot] wants to merge 1 commit into
developfrom
fix/task-artifact-delete-failures

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

​Opened on behalf of @daniel-lxs. View the task or mention @roomote-roomote for follow-up asks.

What changed

Task deletion now aborts when artifact object deletion throws or reports failed objects. The transaction retains task and artifact metadata instead of committing a soft-deleted task whose remaining object-store keys can no longer be retried.

Focused regression coverage verifies that both reported batch failures and thrown storage errors occur before any artifact-row, task, parallel-count, or session mutation. The successful deletion path remains unchanged.

Why this change was made

The previous best-effort path deleted every taskArtifacts row even when S3 returned errors. That erased the only durable mapping to failed object keys and could permanently leak stored artifacts.

Impact

Users can retry task deletion after a transient or partial storage failure without leaving unreachable objects behind. The targeted task-deletion suite passes all 6 tests, and the web package type-check and changed-file formatting checks pass.

Related PRs

@roomote-community

roomote-community Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed 317c082

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant