[Improve] Pin PR review updates above the session composer - #2255
Open
mrubens wants to merge 1 commit into
Open
Conversation
Contributor
| > | ||
| {children} | ||
| <SessionReviewTasksContext.Provider | ||
| value={sessionTasks} |
Contributor
There was a problem hiding this comment.
SessionReviewTasksContext is fed from sessionTasks, but the legacy Fast-session branch intentionally leaves that list empty (page.tsx constructs it with tasks: [] and puts its task data in taskCards). Those Sessions therefore never pass any review tasks into getSessionPrReviews, so a review that is still running has no payload yet and the promised Reviewing… row never appears. Feed an appropriately enriched version of the polled Fast tasks here (the current fast-task query also needs workflow/PR linkage) so active review status works outside unified Sessions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PR-review notifications previously accumulated as repeated prose and action offers in the Session transcript. Show the latest review update for each PR in a compact strip above the composer, keeping it visible while the conversation scrolls. Multiple PRs use expandable status rows with one set of actions open at a time.
The strip retains the existing resolve, auto-resolve, and dismiss actions; shows active linked reviews and reported approval/closure; and opens the review task when available, falling back to the provider PR. Review events now carry structured PR context so grouping, finding counts, and links do not depend on parsing agent prose. Structured review notifications leave the scrolling transcript; ordinary conversation stays there. Legacy offers remain usable without inventing missing PR context.
Includes Session docs and Storybook examples for feedback, reviewing, approval, and multiple PRs. No schema changes.
Screenshots
Real Storybook components in a 420px session pane, using synthetic example data.
Unresolved feedback — review actions stay above the composer
Approved — the review collapses to a compact status row
Multiple PRs — one expanded set of actions at a time
How it was tested
Checklist