[Fix] Session reminders fail when users request a delay in seconds - #2265
Merged
Conversation
Contributor
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 5, 2026 17:58
daniel-lxs
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Follow-up to merged #2239. No linked issue.
Why this PR exists
Second-based reminders were rejected by the minute/hour/day-only grammar. This fixes requests such as "say something in 30 seconds" without accepting fractional or compound textual durations.
What changed
in 30sand seconds aliases for one-shot reminders, andevery 30s x3for bounded recurring checks. Recurring intervals under five minutes still require a run count or end time; cron stays five-field.in 30s, notin 0.5m.Delivery remains best effort. Queue infrastructure and the one-minute lost-hint recovery sweep are unchanged; no exact-time delivery guarantee is introduced.
How it was tested
pnpm lint:fast,pnpm check-types:fast,pnpm knip, focused formatting,git diff --check, and docs validation/link checks pass. Commit and full pre-push hooks pass. A non-failing Knip configuration hint aboutmintremains.Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changesetThe fast static gates listed above were run instead of the full formatting-inclusive commands. No changeset was added.