[Improve] Recommend follow-up work in conversation - #2309
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Improve] Recommend follow-up work in conversation#2309roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
| - Do not return ideas that genuinely require cross-repository execution unless you can tie the launch target to one repository. | ||
| - Each suggestion should cover a different subsystem, flow, or file area when possible. | ||
| - Finish with one \`send_chat_reply\` call: put the concise report summary in \`message\`, set \`purpose\` to \`closeout\`, and put the final structured actions in \`suggestions\` so they appear beneath that report in the originating conversation. | ||
| - Finish with one \`send_chat_reply\` call: put the concise report and actionable recommendations in ordinary prose in \`message\` and set \`purpose\` to \`closeout\`. |
Contributor
There was a problem hiding this comment.
This prompt is also used by the web onboarding scan (apps/web/src/trpc/commands/task-suggestions/onboarding.ts), which launches a Scan with notifySlack: false and no chat context. In that runtime send_chat_reply is not registered, and this PR has removed the only path that persisted workItems(kind='suggestion'). The scan therefore completes without producing onboarding suggestions; ensureTaskSuggestions treats that completed run as empty and will not retry. Keep a non-conversational persistence/output path for onboarding, or split its prompt from chat automation reports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
No linked issue; explicitly requested internal Roomote work.
Why this PR exists
Follow-up recommendations should be part of the conversation: explain useful work, ask what to start, and use the normal task-start flow after acceptance instead of emitting new suggested-task cards.
What changed
actworkflows remain autonomous.New recommendations no longer depend on structured cards or hidden fields for their implementation context. Existing cards and authorized autonomous work retain their behavior.
How it was tested
develop: five Fast/shared-prompt/workflow test files passed (304 tests); three worker reply/API-client/tool-description test files passed (84 tests).pnpm exec oxlint --deny-warnings,pnpm exec turbo lint --log-order grouped --output-logs new-only,pnpm check-types:fast(27 tasks), andpnpm knip. Knip emitted only a non-failing configuration hint to removemintfromignoreBinaries.git diff --checkpassed. The implementation completion review reported no remaining gaps after a stale worker test was corrected.Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs],[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changesetThe exact full lint/type commands above were not run; the pre-push fast type checks, residual lint, oxlint, and implementation-scoped checks passed. No changeset was added in this delivery-only pass.