Skip to content

Fix reversed letters in the IQD and LYD symbols - #1234

Open
mayrsascha wants to merge 1 commit into
RubyMoney:mainfrom
mayrsascha:fix-iqd-lyd-symbols
Open

mayrsascha wants to merge 1 commit into
RubyMoney:mainfrom
mayrsascha:fix-iqd-lyd-symbols

Conversation

@mayrsascha

Copy link
Copy Markdown

The Iraqi and Libyan dinar symbols have their letters in reverse logical order, the same bug #958 fixed for BHD:

before after codepoints after
IQD ع.د د.ع DAL, FULL STOP, AIN
LYD ل.د د.ل DAL, FULL STOP, LAM
  • Every other dinar in currency_iso.json already starts with dal (د, for dinar), followed by the country letter: AED د.إ, BHD د.ب, DZD د.ج, JOD د.ا, KWD د.ك, TND د.ت.
  • CLDR agrees: د.ع. in ar_IQ and د.ل. in ar_LY.
  • Both values date from the initial import of the currency data and were never discussed in an issue or PR.

Changes

  • Swapped the two symbols.
  • Added a formatting spec next to the BHD one.
  • Added a CHANGELOG line under Unreleased.

bin/rake spec (503 examples, 0 failures), bin/rubocop and bin/rbs --no-collection -r money validate pass. My AUTHORS entry is in #1233, so I left it out here to avoid a conflict between the two PRs.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants