Repository navigation
Return a Float from Money#/ for a plain Money divisor on a subclass - #1237
Open
andrewstellman wants to merge 1 commit into
Open
andrewstellman wants to merge 1 commit into
andrewstellman wants to merge 1 commit into
Conversation
andrewstellman
marked this pull request as ready for review
October 10, 2026 22:03
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro, with library defaults (no global settings changed):
Money.new(1000, "USD") / Money.new(100, "USD")returns10.0. With a zero plain Money divisor, the subclass raiseddivided by zeroinstead ofdivided by Money(0).For a subclass receiver and a divisor in another currency, the old code did not convert the divisor. It used the divisor's
to_das a plain number, soSub.new(1000, "USD") / Money.new(400, "GBP")returned#<Sub fractional:250 currency:USD>. The new code converts the divisor through the bank asMoney / Moneydoes, so a missing rate raisesMoney::Bank::UnknownRate.Cause:
Money#/tests the divisor withother.is_a?(self.class)(lib/money/money/arithmetic.rb:205). For a subclass receiver, a divisor that is not an instance of that same subclass (a plainMoney, or another subclass) takes the number branch. The otherMoneychecks in that file useis_a?(Money)(lines 41, 66, 244, 302).The new spec fails without the change and passes with it. Full suite:
503 examples, 0 failures.The method docs say: "+Money/Numeric+ returns +Money+. +Money/Money+ returns +Float+." (
lib/money/money/arithmetic.rb:193).Found by Quality Playbook, an AI code-review tool, with Claude; I reviewed the change.